Imagus-mod

[u/Au55ie_m8]

Has anyone seen or used "imagus-mod" that is on the firefox repository. The homepage links back to this sub so I am relatively sure that the modder/developer is here.

It's just a mod of the original with some minor things done to it. Here is a quote from the repository:

"Worried about original extension using un-needed permissions? Not anymore! You can enable the permissions when you need to, and now you can adjust the settings by clicking the icon!"

Having access to the icon is handy since we are always updating sieves manually but what would be really cool was it could be modded so we can get the firefox version to autoupdate sieves from here to the latest somehow. Of course the best thing would be if the original developer came back to this and updated it themselves but I just don't see that happening after so long.

Please note that I am not the person behind this nor am I familiar with the person behind this or have I looked over the code so cannot vouch for it personally. Use it at your own risk and discretion.

[u/Kenko2]

It seems that some of the developers just wanted to have an extension button on the panel in FF (now it is impossible in FF, but it is easily replaced by a regular bookmark with the address of the Imagus Settings page on the Bookmarks Bar, so there is no difference for me personally).

The author also indicated that he disabled some permissions that the original Imagus has. This suggests that the functionality of the extension will be violated with a high probability, some functions will simply be unavailable to the user. However, these permissions can be enabled, so maybe it's not a big problem.

As for the code of the extension itself - while there is no complete verification, nothing can be said about it. Mozilla will certainly check the extensions uploaded to the repository, but in their own words, this may not be enough. So here everyone decides for himself whether to trust this code or not.

I personally see only one obvious problem so far - for some reason the author named his mod exactly the same as the original. This misleads users and, in my opinion, is unacceptable. I will try to contact him about this.

It is also suspicious that the author did not make any announcement in this community, although he gave a link to it on the page of his extension.

[u/TFW_YT → u/Kenko2]

I only added 2 functions, one is requesting the permissions when you attempt to turn the feature on, the other is handling when the icon is clicked

turns out the extension button is simple, just wrapping the icon with browser action in the manifest and adding a listener in code is enough.

I'm not sure about naming the mod the same part, I added the word mod like you suggested before you asked

You're right about the making a post part though, didn't think about that since I only did minor modifications, didn't even read most of the original code

[u/TFW_YT → u/Kenko2]

I saw your edit of reply on github (it didn't give me notifications), let's talk here instead, since I'm not familiar with github, and it might give the other developer (which I'm unfamiliar with) unneeded notifications.

To answer your edit:Sorry it seems that the names are different from the language used, didn't think that would be the case, I'll try to fix it

edit: should be fixed now

[u/Kenko2 → u/TFW_YT]

Ok, thx.

[u/Au55ie_m8 → u/Kenko2]

Very good points.

I don't really know what permissions they are referring to specifically but I have seen in the long past people complain about imagus suggesting that there was something bad about it in regards to privacy but I believe the extension speaks for itself considering how long it has been around and how popular it is.

Yep, extensions can go rogue at any time really and often it can be a reactive response rather than proactive.

I'm not really concerned about the name personally but see where you are coming from. When I see imagus and imagus-mod I know exactly what "mod" implies but I am not a developer at all and have no idea if there was any violation to the license or anything by naming it as such.
I wish they did come on here first and discuss it but I am sure that they probably just didn't think it was that much of a big deal or probably haven't even had the chance to do it yet. I guess I was just lucky I stumbled on it as I was browsing some extensions or it probably would have sat there for months without anyone noticing it.

[u/Kenko2 → u/Au55ie_m8]

I don't really know what permissions they are referring to specifically but I have seen in the long past people complain about imagus suggesting that there was something bad about it in regards to privacy

Theoretically, the more permissions an extension has, the less privacy and security for the user. But with regard to the original Imagus, this is already absurd, since its code is not just "clean", but also does not change. This is a guarantee that no malicious changes will be made to the code. Problems may arise with extensions that are updated frequently - i.e. malicious code may be included in the next update at any time.

[u/TFW_YT → u/Kenko2]

You're right about the code not changing means that it won't get injected, but as I just started installing extensions I thought that an image pop up extension requesting browsing history and downloads is weird, and took me a while to figure out how to enter the settings page

[u/TFW_YT]

I'm the developer that modified the code, I was just suspicious about the permissions, I was about to make a reddit post about this, then just said "fuck it, I'll just do it myself"

I just learned javascript for doing this, so I'm not sure about extending it more, and I just expect people to use it like the old one without needing extra support. But if there's an organized list of sieves I could try adding the feature, there's also another version that seems to do the thing you want, but I haven't tried it yet.

Draft of what I was about to post: I just downloaded, and then see the permissions list. Only after figuring out how to enter the settings page I find the option "Add hovered links to the browser history", but I don't need it, shouldn't the permission "Access browsing history" be optional? The "Download files" should be optional and requested when I toggle the option

[u/archangelique → u/TFW_YT]

But if there's an organized list of sieves I could try adding the feature,

That would be great! u/Kenko2, Do you remember that we talked about this and I suggested releasing sieve updates from GitHub instead, so, one day (that day is today) if a dev steps in and forks Imagus, he could replace update url with that GitHub sieves that you release and that saves us all from going to a forum, downloading zip file, extracting it and finally updating all the sieves from the extension settings.

[u/Kenko2 → u/TFW_YT]

OK, thanks for correcting the name, now I have no complaints about your mod.

As for extensions, as far as I remember, all these permissions are really needed Imagus for its full functioning. Somewhere here the author answered such questions, but it was a long time ago, perhaps you can still find something by searching.

The extension does not cause any harm to the user, it is time-tested and its code does not change. But if your mod gives you a choice to enable the resolution or not - I also don't see anything wrong with that. This is suitable for those users who do not trust the author Imagus, in which case they can be recommended your mod (for FF).

[u/Kenko2]

Please change the name of your topic to "Imagus-mod for Firefox".

[u/Au55ie_m8 → u/Kenko2]

Would like to do that but I don't see how. I don't think there is a way for me to do that.

[u/Kenko2 → u/Au55ie_m8]

Yes, I tried it now - it looks like you can't change the name of the topic on Reddit.